Indentation - fixing "lone" else lines #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very much a work in progress, but seems to be going well.
|
Are you still working on this? If not, I'd appreciate closing the issue and leaving the branch up for someone else to continue the work, and |
|
Done! Created #73. Closing this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, "lone"
elselines don't seem to indent properly. I'm trying to fix that.Current progress on this branch (you should be able to
=Gfrom the first line and have the same result):{ if (cond) branchA() else branchB(); // not properly indented yet } { if (cond) branchA() else branchB(); if (cond) if (foo) blk: { break :blk branchA(); } else branchB(); else branchB(); const val = if (cond) branchA(); else branchB(); const val = if (cond) branchA(); else branchB(); const val = if (cond) blk: { break :blk branchA(); } else blk: { break :blk branchB(); } }Suggestions are appreciated!
Also, the method I'm doing uses a for loop - I'm not sure if that's very efficient so that might be a thing to be changed later.